On Apr 22, 2017, at 12:10 PM, Stoney Jackson ***@***.***> wrote: Hi @janetlndavis 👋 :) Thanks for the PR! It's so cool to have another collaborator! Skimming through, it looks like there are links specific to your class mixed in which will make it difficult to accept and merge the PR as is. I'm not sure what the best way to deal with this. Probably breaking this into smaller separate changes in separate PRs would be best. But this might be a lot of work. Maybe do this for the ones you feel strongly about? Or if you don't want to do even that much work, just put in an issue with the top problems you fixed in yours and how; then you don't need to do any fancy git wizardry. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Hi Janet, The mistake was mine. The PR was not to my repository, but was back to your fork :) You might hold off doing a lot of work filtering through your changes. I’ve started a major rewrite ( foss2serve#26). If you have time, feedback on that would be helpful! I wrote this on my flight back from the last POSSE. So it’s definitely not a final product yet. -- Stoney Jackson Sent with Airmail On April 22, 2017 at 4:29:10 PM, janetlndavis ***@***.***) wrote: Stoney, I don't remember making a pull request, which suggests I did it unintentionally. Sorry to make work for you. If you'd like I could go over it this summer and try to sift out the non-class-specific things? -- Janet Davis Sent from my "smart" phone, in haste, with auto-(in)correct > On Apr 22, 2017, at 12:10 PM, Stoney Jackson ***@***.***> wrote: > > Hi @janetlndavis 👋 :) > > Thanks for the PR! It's so cool to have another collaborator! > > Skimming through, it looks like there are links specific to your class mixed in which will make it difficult to accept and merge the PR as is. I'm not sure what the best way to deal with this. Probably breaking this into smaller separate changes in separate PRs would be best. But this might be a lot of work. Maybe do this for the ones you feel strongly about? Or if you don't want to do even that much work, just put in an issue with the top problems you fixed in yours and how; then you don't need to do any fancy git wizardry. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABVH7hknbVU2FlSmHh-WLnBL6oWeyU-4ks5rymMVgaJpZM4MBO1-> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AS6UU-T5uxmCLIJLxNUI1WT5UXBHgl3qks5rzLedgaJpZM4MBO1->.